Something possibly controversial that needs to be said:
People who apply for PGV now (since the TC decision) are part of the problem.
Now that it is abundantly clear that the Portugal political and legal system has no intention of honoring its promises, new applicants are simply rewarding the scammers.
They say you are “eligible for citizenship in 10 years”, but as we all now know, that’s 10 years to apply for citizenship from first residence card, which doesn’t come immediately, and then you have to wait for IRN processing, which is now taking 3-5 years, or even if reverting back to historical averages will be 2 years. So your timeline is 12 years minimum, 13-15 years optimistically, and 17-19 years if current average processing times continue.
The state has now made clear via both the actions the actions of all major parties in the legislature and the TC decision that it has no intention of protecting you from changes to the terms of citizenship qualification during this time. It could, and very well may, add:
(1) Increased language requirements;
(2) Physical presence requirements, which may be required for citizenship even if not required for GV residence renewal;
(3) Amorphous, discretionary “integration” requirements.
The risk of these changes is not remote or imaginary. Rather, elements of these changes were an actual AD (current ruling) party position less than one year ago: Moving the Goalposts on Citizenship again - #41 by PTbound
The Portuguese state is untrustworthy. It doesn’t respect your investment. It certainly doesn’t respect your time.
All of the seven points I mentioned in my original post are still true or worsened:
If you absolutely must obtain an EU country’s citizenship, ask yourself why, examine the answer, and find another way. You should be able to do better than 15 years.
Going forward, if you apply for Portugal Golden Visa knowing what is now known, you are not buying a “call option”. You are contributing to the destruction of the rule of law. You are supporting a system of dishonesty that has created immense misery for people like yourself. You are also likely funding your own misery and the misery of your family.
Portugal Golden Visa is an unwise, irresponsible, and unethical choice.
Addendum: Optimize, a firm that just a few weeks ago ran a sponsored feature in IMI Daily falsely arguing that citizenship was not part of PGV, is now running this ad stating: “Rules May Change Soon”.
Really? Which “rules”? The golden visa residence permit terms aren’t currently under debate, so they must be referring to the citizenship rules! 
The ad placement is perfect – look at the URL 
